Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): Reduce noise from actions labeling #1442

Merged
merged 1 commit into from
May 17, 2023
Merged

ci(github): Reduce noise from actions labeling #1442

merged 1 commit into from
May 17, 2023

Conversation

MichaelsJP
Copy link
Member

@MichaelsJP MichaelsJP commented May 17, 2023 •
edited

This should reduce the PR noise from the conventional label assignment.

Pull Request Checklist

  • 1. I have rebased the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@MichaelsJP MichaelsJP linked an issue May 17, 2023 that may be closed by this pull request
ci: Reduce the PR noise from the conventional title action #1440
Closed
@takb takb added this to To do in ors general May 17, 2023
@MichaelsJP MichaelsJP force-pushed the ci/1440-chore-reduce-the-pr-noise-from-the-conventional-title-action branch from 5a4c608 to d9d8c98 Compare May 17, 2023 08:29
@github-actions github-actions bot added ci 👷 and removed ci 👷 labels May 17, 2023
@MichaelsJP MichaelsJP changed the title ci(github,action): Remove synchronized from the event triggers ci(github): Remove synchronized from the event triggers May 17, 2023
@github-actions github-actions bot added ci 👷 and removed ci 👷 labels May 17, 2023
@MichaelsJP MichaelsJP force-pushed the ci/1440-chore-reduce-the-pr-noise-from-the-conventional-title-action branch from 4833633 to f1e3f48 Compare May 17, 2023 09:27
@github-actions github-actions bot added ci 👷 and removed ci 👷 labels May 17, 2023
@MichaelsJP MichaelsJP force-pushed the ci/1440-chore-reduce-the-pr-noise-from-the-conventional-title-action branch from f1e3f48 to 281e732 Compare May 17, 2023 09:28
@github-actions github-actions bot added ci 👷 and removed ci 👷 labels May 17, 2023
@MichaelsJP MichaelsJP force-pushed the ci/1440-chore-reduce-the-pr-noise-from-the-conventional-title-action branch from 281e732 to 8bbfc02 Compare May 17, 2023 09:29
@github-actions github-actions bot added ci 👷 and removed ci 👷 labels May 17, 2023
@MichaelsJP MichaelsJP closed this May 17, 2023
@MichaelsJP MichaelsJP reopened this May 17, 2023
ors general automation moved this from To do to Review May 17, 2023
@github-actions github-actions bot added ci 👷 and removed ci 👷 labels May 17, 2023
@MichaelsJP MichaelsJP changed the title ci(github): Remove synchronized from the event triggers chore(github): Remove synchronized from the event triggers May 17, 2023
@MichaelsJP MichaelsJP changed the title chore(github): Remove synchronized from the event triggers ci(github): Remove synchronized from the event triggers May 17, 2023
@MichaelsJP
ci(github,action): Rework conventional commit checks
a80fdf3 
The action are splitted into two now. conventional-commit.yml checks the commits and the title each time somethin happens in the PR. conventional-label.yml is only executed if the PR title is changed, the PR freshly opened, or set to ready for review. This prevents the action from spamming the PR history.
@MichaelsJP MichaelsJP force-pushed the ci/1440-chore-reduce-the-pr-noise-from-the-conventional-title-action branch from b93080c to a80fdf3 Compare May 17, 2023 11:46
@MichaelsJP MichaelsJP marked this pull request as ready for review May 17, 2023 11:47
@github-actions github-actions bot removed the ci 👷 label May 17, 2023
@MichaelsJP MichaelsJP enabled auto-merge May 17, 2023 11:47
@MichaelsJP MichaelsJP requested a review from takb May 17, 2023 11:47
@github-actions github-actions bot added ci 👷 and removed ci 👷 labels May 17, 2023
@MichaelsJP MichaelsJP changed the title ci(github): Remove synchronized from the event triggers ci(github): Reduce noise from actions labeling May 17, 2023
@github-actions github-actions bot added ci 👷 and removed ci 👷 labels May 17, 2023
takb
takb approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@MichaelsJP MichaelsJP merged commit 1bcbc8c into master May 17, 2023
21 checks passed
ors general automation moved this from Review to Awaiting release May 17, 2023
@MichaelsJP MichaelsJP deleted the ci/1440-chore-reduce-the-pr-noise-from-the-conventional-title-action branch May 17, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takb takb takb approved these changes

Assignees

@MichaelsJP MichaelsJP

Labels
ci 👷
Projects
ors general
  
Awaiting release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: Reduce the PR noise from the conventional title action
2 participants
@MichaelsJP @takb