-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api-tests): Test based on mock HERE traffic data #1449
Conversation
35ab124
to
2e06b6c
Compare
Not sure why the API test still fails on the GitHub runner, as for me it passes locally. |
The API test fails on the GitHub runner with the following:
The failure could be related to the fact that the server on which the API test is being executed uses a different time zone than the internally hard coded "Europe/Berlin". |
With the "fix" introducing multiple snapping points it fails for me locally too 🙈 |
With the updated test dataset the reported difference is now:
|
2a36fb0
to
e387c03
Compare
No duplicate edges anymore. The two bridges are now represented as one ways on each side.
In order to integrate GH's map matching we facade it with the ORS MapMatcher inteface.
Reversing the geometry in TrafficLink does not seem to make sense and leads to worse results. Therefore, the reversion is commented out, but left in the code for future investigation.
576e783
to
2e75318
Compare
openrouteservice/src/main/java/org/heigit/ors/mapmatching/GhMapMatcher.java
Outdated
Show resolved
Hide resolved
...routeservice/src/main/java/org/heigit/ors/routing/graphhopper/extensions/ORSGraphHopper.java
Outdated
Show resolved
Hide resolved
openrouteservice/src/main/java/org/heigit/ors/mapmatching/GhMapMatcher.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Julian Psotta <22392104+MichaelsJP@users.noreply.github.com>
4c67c86
to
abcddaa
Compare
LGTM |
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes #1403.
Also: some further improvements on #1430
Information about the changes
API test for the functionality of traffic-enabled routing based on HERE-like traffic data.