Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cve): Upgrade to eclipse-temurin:17.0.7_7-jre-alpine (#1451) #1452

Merged
merged 2 commits into from
May 25, 2023

Conversation

MichaelsJP
Copy link
Member

@MichaelsJP MichaelsJP commented May 25, 2023

Pull Request Checklist

  • 1. I have rebased the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes #1447 .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@github-actions github-actions bot added the fix label May 25, 2023
@takb takb added this to To do in ors general May 25, 2023
@github-actions github-actions bot added fix and removed fix labels May 25, 2023
@MichaelsJP MichaelsJP force-pushed the fix/eclipse-temurin-vulnerability branch from 63fe497 to 5d7f258 Compare May 25, 2023 13:35
@MichaelsJP MichaelsJP self-assigned this May 25, 2023
@MichaelsJP MichaelsJP marked this pull request as ready for review May 25, 2023 13:35
@github-actions github-actions bot added fix and removed fix labels May 25, 2023
@MichaelsJP MichaelsJP enabled auto-merge (squash) May 25, 2023 13:36
@MichaelsJP MichaelsJP requested a review from takb May 25, 2023 13:36
@github-actions github-actions bot added fix and removed fix labels May 25, 2023
@MichaelsJP MichaelsJP mentioned this pull request May 25, 2023
@MichaelsJP MichaelsJP requested a review from aoles May 25, 2023 13:50
@github-actions github-actions bot added fix and removed fix labels May 25, 2023
sean-redmond and others added 2 commits May 25, 2023 15:55
Co-authored-by: Sean Redmond <sean.redmond1@gmail.com>
A version pin on the x.x version seems unreasonable and only makes the maintenance harder.
@MichaelsJP MichaelsJP force-pushed the fix/eclipse-temurin-vulnerability branch from 5d7f258 to c63f45d Compare May 25, 2023 13:55
@MichaelsJP MichaelsJP merged commit e14ea8b into master May 25, 2023
15 checks passed
ors general automation moved this from To do to Awaiting release May 25, 2023
@MichaelsJP MichaelsJP deleted the fix/eclipse-temurin-vulnerability branch May 25, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ors general
  
Awaiting release
Development

Successfully merging this pull request may close these issues.

CVE-2023-1255
3 participants