ci(docker): Fix the docker build github workflow #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelsJP
force-pushed
the
fix-wrong-multi-arch-docker-build
branch
17 times, most recently
from
bfaf2f2
to
c3937f2
Compare
MichaelsJP
force-pushed
the
fix-wrong-multi-arch-docker-build
branch
2 times, most recently
from
2ed558c
to
ba01504
Compare
MichaelsJP
force-pushed
the
fix-wrong-multi-arch-docker-build
branch
5 times, most recently
from
fc8004e
to
8ca616d
Compare
MichaelsJP
force-pushed
the
fix-wrong-multi-arch-docker-build
branch
from
8ca616d
to
79decbe
Compare
Currently, the workflow doesn't seem to correctly build for arm64 platforms. This is fixed now for the nightly images and the release workflow. arm64 tends to be really slow on building graphs while being emulated on an amd64 machine. Because of this the arm64 docker tests are only executed when the PR is set to active. Additionally, the grype checks now test both amd64 and arm64 platforms correctly.
MichaelsJP
force-pushed
the
fix-wrong-multi-arch-docker-build
branch
from
79decbe
to
f833aae
Compare
MichaelsJP
changed the title
koebi
reviewed
Jun 1, 2023
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
koebi
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the workflow doesn't seem to correctly build for arm64 platforms.
The current base image doesn't support arm64 so we need to take another one.
amazoncorretto:17.0.7-alpine3.17is the only major java build that supports alpine and arm64. To keep vulnerabilities low we should stick to this. Any debian/ubuntu-based images are just full to the top with CVEs.Partially fixes #1338 .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)