Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make log location configurable via env var #1530

Merged
merged 2 commits into from
Aug 23, 2023
Merged

feat: make log location configurable via env var #1530

merged 2 commits into from
Aug 23, 2023

Conversation

takb
Copy link
Contributor

@takb takb commented Aug 23, 2023

Information about the changes

  • Made log files location configurable by env var called ORS_LOG_LOCATION
  • added entry to setenv.sh pointing to %{ors_local_folder}/logs in the specs file

@takb takb added this to To do in ors general Aug 23, 2023
@MichaelsJP
Copy link
Member

The rpm environment check scripts should test for the log config env.
Maybe we can verify somehow that the logs are written in the correct folder

@takb takb marked this pull request as ready for review August 23, 2023 13:05
@github-actions github-actions bot added feature and removed feature labels Aug 23, 2023
@takb takb enabled auto-merge August 23, 2023 13:05
@takb takb requested a review from MichaelsJP August 23, 2023 13:06
@github-actions github-actions bot added feature and removed feature labels Aug 23, 2023
@takb
Copy link
Contributor Author

takb commented Aug 23, 2023

Checks added.

@takb takb merged commit 73add36 into releases/v7.2.x Aug 23, 2023
14 checks passed
ors general automation moved this from To do to Awaiting release Aug 23, 2023
@takb takb deleted the feat/config-log-location branch August 23, 2023 14:58
@MichaelsJP
Copy link
Member

LGTM

@takb takb mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelsJP MichaelsJP MichaelsJP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ors general
  
Awaiting release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takb @MichaelsJP