feat: automatic graph download #1574
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blobCreated was not present in yaml, but was served by the api endpoint
tried experimentally, commented out
graph ghz files might be downloaded but not yet extracted. Another download is only necessary, if there is a newer file in the repository
…e, if a URL is set
…ractions of the same ghz
MichaelsJP
force-pushed
the
profile-hash
branch
from
56c0008
to
b919ccd
Compare
Co-authored-by: jhaeu <138764906+jhaeu@users.noreply.github.com>
# Conflicts: # .github/workflows/run_maven_tests.yml # docs/technical-details/Graph-Management.md # ors-api/ors-config.yml # ors-api/src/main/java/org/heigit/ors/api/Application.java # ors-api/src/main/java/org/heigit/ors/api/EngineProperties.java # ors-api/src/main/java/org/heigit/ors/api/servlet/listeners/ORSInitContextListener.java # ors-api/src/main/resources/application.yml # ors-engine/pom.xml # ors-engine/src/main/java/org/heigit/ors/config/EngineConfig.java # ors-engine/src/main/java/org/heigit/ors/routing/RoutingProfile.java # ors-engine/src/main/java/org/heigit/ors/routing/RoutingProfileManager.java # ors-engine/src/main/java/org/heigit/ors/routing/configuration/RouteProfileConfiguration.java # pom.xml
Changes on main, that were merged into the branch, broke the implementation of the detection if local graph building or a graph repo should be used. This approach was controversial anyway. We replaced it with explicit properties for graph management. This has the side effect, that a graph is built locally, if it is not found in the repository and an existing source_file is configured. Whether this behavior is desirable is questionable, because the configured pbf could be of a different extent than configured.
|
jhaeu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)