New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly resolve access to ways tagged with hgv=delivery
#1748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small note, other than that it looks good :)
Edit: I did check with the request mentioned in the Issue and can confirm that the fix does what it should :)
...it/ors/routing/graphhopper/extensions/storages/builders/HeavyVehicleGraphStorageBuilder.java
Show resolved
Hide resolved
As discussed, @aoles will add some tests for this tagging scenario. |
9fe1347
to
9cb9ea9
Compare
Thanks @koebi for reviewing the PR ❤️ I've added the test, should be fine to go forward with the merge. Cheers! |
11c0663
to
88d02bb
Compare
Quality Gate passedIssues Measures |
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes #1743.
Information about the changes
hgv=delivery
is allowed for vehicle typedelivery
but not forhgv
.hgv=delivery
tag were blocked for vehicle typedelivery
but accessible tohgv
.