Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly resolve access to ways tagged with hgv=delivery #1748

Merged
merged 3 commits into from Mar 21, 2024

Conversation

aoles
Copy link
Member

@aoles aoles commented Mar 12, 2024

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes #1743.

Information about the changes

  • Key functionality added: routing on ways tagged as hgv=delivery is allowed for vehicle type delivery but not for hgv.
  • Reason for change: ways with hgv=delivery tag were blocked for vehicle type delivery but accessible to hgv.

@github-actions github-actions bot added the fix label Mar 12, 2024
@takb takb added this to To do in ors general Mar 12, 2024
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note, other than that it looks good :)

Edit: I did check with the request mentioned in the Issue and can confirm that the fix does what it should :)

ors general automation moved this from To do to Review Mar 19, 2024
@koebi
Copy link
Collaborator

koebi commented Mar 19, 2024

As discussed, @aoles will add some tests for this tagging scenario.

@aoles aoles force-pushed the fix/hgv_access_restrictions branch from 9fe1347 to 9cb9ea9 Compare March 20, 2024 13:30
@github-actions github-actions bot added fix and removed fix labels Mar 20, 2024
@aoles aoles marked this pull request as ready for review March 20, 2024 13:33
@github-actions github-actions bot added fix and removed fix labels Mar 20, 2024
@aoles
Copy link
Member Author

aoles commented Mar 20, 2024

Thanks @koebi for reviewing the PR ❤️ I've added the test, should be fine to go forward with the merge. Cheers!

@aoles aoles force-pushed the fix/hgv_access_restrictions branch from 11c0663 to 88d02bb Compare March 20, 2024 16:56
@jhaeu jhaeu added this to the V8 Release milestone Mar 21, 2024
@aoles aoles requested a review from koebi March 21, 2024 09:00
@github-actions github-actions bot added fix and removed fix labels Mar 21, 2024
Copy link

sonarcloud bot commented Mar 21, 2024

@aoles aoles enabled auto-merge March 21, 2024 10:12
@aoles aoles merged commit 19d5122 into main Mar 21, 2024
32 checks passed
ors general automation moved this from Review to Awaiting release Mar 21, 2024
@aoles aoles deleted the fix/hgv_access_restrictions branch March 21, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
ors general
  
Awaiting release
Development

Successfully merging this pull request may close these issues.

hgv=delivery-tags not considered properly
3 participants