Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: non-positive values of maximum_grade_level encoder config parameter #1775

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

aoles
Copy link
Member

@aoles aoles commented Apr 5, 2024

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly..

Information about the changes

Document missing configuration feature of entirely disabling routing on tracks...

@takb takb added this to To do in ors general Apr 5, 2024
@aoles aoles force-pushed the docs/negative_max_grade_level branch from b3f09f8 to aaa0675 Compare April 16, 2024 07:55
@aoles aoles force-pushed the docs/negative_max_grade_level branch from aaa0675 to 614df16 Compare April 16, 2024 08:27
@aoles aoles changed the title docs: negative values of maximum_grade_level encoder config parameter docs: non-positive values of maximum_grade_level encoder config parameter Apr 16, 2024
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@takb takb enabled auto-merge April 16, 2024 12:01
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@takb takb merged commit 9472c65 into main Apr 16, 2024
29 checks passed
ors general automation moved this from To do to Awaiting release Apr 16, 2024
@takb takb deleted the docs/negative_max_grade_level branch April 16, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
ors general
  
Awaiting release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants