Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised restrictions #407

Merged
merged 9 commits into from
Feb 1, 2019
Merged

Revised restrictions #407

merged 9 commits into from
Feb 1, 2019

Conversation

aoles
Copy link
Member

@aoles aoles commented Jan 30, 2019

Pull Request Checklist

  • 1. I have merged the latest version of the development branch into my feature branch and all conflicts have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the app.config file, I have added these to the app.config.sample file along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset (at least Germany) and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the importer etc.), I have generated longer distance routes for the affected profiles with different options (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end points generated from the current live ORS. If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage and why the change was needed.

Fixes #396.

Information about the changes

In order to reduce the amount of ways affected by dynamic weights the following avoid_features has been removed :pavedroads, unpavedroads, tunnels, tracks and hills. The decision was based on either the fact that OSM data for these restrictions is incomplete or there is no clear use case for them. Furthermore, maximum_speed option, as well as difficulty settings such as fitness_level and maximum steepness for cycling- and walking- profiles has been removed This was motivated by the fact that the results produced with these options were not always reliable , and that we could not use them with CALT anyway.

@rabidllama rabidllama merged commit 959a264 into api_refactoring Feb 1, 2019
@aoles aoles deleted the revised_restrictions branch January 10, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants