Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor eventBus #324

Closed
TheGreatRefrigerator opened this issue Jan 26, 2023 · 0 comments · Fixed by #326
Closed

Refactor eventBus #324

TheGreatRefrigerator opened this issue Jan 26, 2023 · 0 comments · Fixed by #326
Assignees
@koebi

Comments

@TheGreatRefrigerator
Copy link
Collaborator

TheGreatRefrigerator commented Jan 26, 2023 •
edited

Currently, the eventBus is attached to the vue instance which only makes it usable in specific scopes or requires the passing of those to the next scope (e.g. to promise).
During testing it is not usable consistently (exists e.g. during MapView component testing but doesn't during App component testing.).

Should be refactored to be a standalone common module, that can be imported on demand and directly be used.
Enables consistent testing using cypress spies.

To do:
Implementation similar to https://www.digitalocean.com/community/tutorials/vuejs-global-event-bus
and replacement of *.eventBus.* with EventBus.* (+ import)
TheGreatRefrigerator added a commit that referenced this issue Jan 26, 2023
@TheGreatRefrigerator
test: Migrate app-render.spec.js
128cf64 
- remove unused lines from map-view.js that conflict with test, as
  the translation returned is a string instead of an object
- contains code to be uncommented or adjusted after #324
  has been dealt with
- remove old spec
TheGreatRefrigerator added a commit that referenced this issue Jan 27, 2023
@TheGreatRefrigerator
test: Migrate app-render.spec.js
9740abe 
- remove unused lines from map-view.js that conflict with test, as
  the translation returned is a string instead of an object
- contains code to be uncommented or adjusted after #324
  has been dealt with
- remove old spec
TheGreatRefrigerator added a commit that referenced this issue Jan 27, 2023
@TheGreatRefrigerator
test: Migrate app-render.spec.js
3c842ed 
- remove unused lines from map-view.js that conflict with test, as
  the translation returned is a string instead of an object
- contains code to be uncommented or adjusted after #324
  has been dealt with
- remove old spec
Merged
koebi added a commit that referenced this issue Jan 30, 2023
@koebi
refactor: move eventBus to standalone module
5ae3b42 
Fixes #324
@koebi koebi mentioned this issue Jan 30, 2023
Merged
TheGreatRefrigerator pushed a commit that referenced this issue Jan 30, 2023
@koebi @TheGreatRefrigerator
refactor: move eventBus to standalone module
8acd75e 
Fixes #324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koebi koebi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move eventBus to standalone module GIScience/ors-map-client
2 participants
@koebi @TheGreatRefrigerator