Skip to content

Commit

Permalink
docs: add TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
koebi committed May 15, 2024
1 parent 58b2848 commit a0c050b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ORStools/common/directions_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,11 @@ def get_extra_info_features_directions(response: dict, extra_info_order: list[st
values = extra_info[key]["values"]
for val in values:
for i in range(val[0], val[1]):
# TODO: translate integer val[2] to readable value according to BE docs
extras_list[key].append(val[2])

for i in range(len(coordinates) - 1):
# TODO: dissolve, but is one layer per extra info more valuable?
feat = QgsFeature()
qgis_coords = [QgsPoint(x, y, z) for x, y, z in coordinates[i : i + 2]]
feat.setGeometry(QgsGeometry.fromPolyline(qgis_coords))
Expand Down
1 change: 1 addition & 0 deletions ORStools/proc/directions_points_layer_proc.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def __init__(self):
self.EXTRA_INFO,
self.tr("Extra Info"),
options=EXTRA_INFOS,
# TODO: allowMultiple=False? This way, we wouldn't have to worry about dissolving more stuff.
allowMultiple=True,
optional=True,
),
Expand Down

0 comments on commit a0c050b

Please sign in to comment.