Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

120 removing blue lines in ors tool #192

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Conversation

merydian
Copy link
Collaborator

@merydian merydian commented Nov 13, 2023

Removes the blue lines every time the red X button is clicked.

@merydian merydian requested a review from koebi November 13, 2023 12:22
@merydian merydian linked an issue Nov 13, 2023 that may be closed by this pull request
@merydian merydian linked an issue Nov 27, 2023 that may be closed by this pull request
6 tasks
@merydian merydian removed a link to an issue Nov 27, 2023
6 tasks
@koebi
Copy link
Collaborator

koebi commented Dec 5, 2023

Steps to reproduce artifact blue lines:

  1. Open Plugin
  2. Click "+"
  3. Add Points (closing the plugin automatically and creating blue lines)
  4. re-open plugin (since it got closed)
  5. click "+" button, resetting points but keeping blue lines

@koebi koebi added this to the Version 1.7 milestone Dec 15, 2023
@koebi koebi force-pushed the 120-removing-blue-lines-in-ors-tool branch from 3573380 to 814ee20 Compare December 22, 2023 08:40
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I fear that this will come up again at some point, but that will hopefully mean that someone has reproducible steps, and we can fix it then :)

@koebi koebi merged commit 426cd9a into main Dec 22, 2023
2 checks passed
@koebi koebi deleted the 120-removing-blue-lines-in-ors-tool branch December 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing blue lines in ORS TOOL
2 participants