Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace qt QSettings with QgsSettings #243

Merged
merged 2 commits into from
May 8, 2024
Merged

feat: replace qt QSettings with QgsSettings #243

merged 2 commits into from
May 8, 2024

Conversation

merydian
Copy link
Collaborator

@merydian merydian commented May 3, 2024

The benefit of this approach is, that we can provide one single config file within our organization, which is considered of each QGIS installed on the user machines.
@danceb

@merydian merydian linked an issue May 3, 2024 that may be closed by this pull request
Using QgsSettings() instead of QSettings() to consider global QGIS config #239
Closed
@merydian merydian marked this pull request as ready for review May 3, 2024 07:11
@merydian merydian requested a review from koebi May 3, 2024 07:11
koebi
koebi requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Can you add a line to the changelog, please?

@koebi koebi merged commit b8eace2 into main May 8, 2024
2 checks passed
@koebi koebi deleted the 239-using-qgssettings-instead-of-qsettings-to-consider-global-qgis-config branch May 8, 2024 13:58
@merydian merydian restored the 239-using-qgssettings-instead-of-qsettings-to-consider-global-qgis-config branch May 10, 2024 07:19
@merydian merydian deleted the 239-using-qgssettings-instead-of-qsettings-to-consider-global-qgis-config branch May 10, 2024 07:19
koebi pushed a commit that referenced this pull request May 10, 2024
@merydian @koebi
feat: replace qt QSettings with QgsSettings (#243)
92323f4 
This consider the use of global configuration via the qgis_global_settings.ini

More details in the corresponding issue/links therein.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koebi koebi koebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using QgsSettings() instead of QSettings() to consider global QGIS config
2 participants
@merydian @koebi