Rename save_vertices.png to icon_save.png for consistency #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need a changelog entry for this? |
koebi
reviewed
May 10, 2024
ORStools/gui/ORStoolsDialogUI.ui
Outdated
| @@ -387,10 +387,10 @@ | |||
| <property name="checked"> | |||
| <bool>false</bool> | |||
| </property> | |||
| <property name="collapsed"> | |||
There was a problem hiding this comment.
Do you have an explanation what these stdset="0" do?
There was a problem hiding this comment.
Oversaw that this changed... They appear to set the standard value for the property, with 0 meaning False. Should i remove them again? I think they appeared after saving in QtCreator.
There was a problem hiding this comment.
Ah. I guess so, since we don't want a value set?
koebi
approved these changes
May 10, 2024
koebi
deleted the
247-rename-save_verticespng-to-icon_savepng-for-consistency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.