Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove crosby, protbuf dependency & sonarbug #384

Merged
merged 7 commits into from
May 17, 2021
Merged

Conversation

rtroilo
Copy link
Member

@rtroilo rtroilo commented May 17, 2021

This PR removes the crosby.binary osm pbf implementation from our repository and replace them with a dependency to:

    <dependency>
        <groupId>org.openstreetmap.pbf</groupId>
        <artifactId>osmpbf</artifactId>
        <version>1.5.0</version>
    </dependency>

It also removes the dependency to google protobuf from the oshdb module. Because we only used the varint encoding from that library and this encoding is a standard, so we provide our own implementation for that.

Corresponding issue

Closes #269, #295

New or changed dependencies

  • removed: com.google.protobuf.protobuf-java from oshdb module
  • added: org.openstreetmap.pbf.osmpbf to oshdb-tool/oshdb-parser module

Checklist

@rtroilo rtroilo added the code quality Related to our standards for 'good' code label May 17, 2021
@rtroilo rtroilo added this to the release 0.7.0 milestone May 17, 2021
@rtroilo rtroilo requested a review from tyrasd May 17, 2021 12:57
@rtroilo rtroilo added the waiting for review This pull request needs a code review label May 17, 2021
@tyrasd
Copy link
Member

tyrasd commented May 17, 2021

  • I have updated the CHANGELOG.md

I'd say this is not necessary in this case, since the change is purely internal and doesn't change anything for end users. I'll strike it out above.

@tyrasd tyrasd added the dependencies referes to one of our dependencies label May 17, 2021
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments inline

@tyrasd tyrasd added the breaking This will introduce an incombability to previous versions. Documentation update compulsory label May 17, 2021
tyrasd
tyrasd previously approved these changes May 17, 2021
tyrasd
tyrasd previously approved these changes May 17, 2021
@tyrasd tyrasd self-requested a review May 17, 2021 16:06
@tyrasd tyrasd removed the waiting for review This pull request needs a code review label May 17, 2021
@rtroilo rtroilo merged commit da0c065 into master May 17, 2021
@rtroilo rtroilo deleted the remove-crosby-protbuf branch May 17, 2021 16:39
@joker234 joker234 linked an issue Jun 2, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This will introduce an incombability to previous versions. Documentation update compulsory code quality Related to our standards for 'good' code dependencies referes to one of our dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make module naming scheme more consistent (e.g. etl -> oshdb-util-etl)
2 participants