-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove crosby, protbuf dependency & sonarbug #384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd say this is not necessary in this case, since the change is purely internal and doesn't change anything for end users. I'll strike it out above. |
rtroilo
force-pushed
the
remove-crosby-protbuf
branch
from
May 17, 2021 13:26
14acf7c
to
fce2202
Compare
tyrasd
reviewed
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few comments inline
oshdb/src/main/java/org/heigit/ohsome/oshdb/impl/osh/OSHNodeImpl.java
Outdated
Show resolved
Hide resolved
oshdb/src/main/java/org/heigit/ohsome/oshdb/impl/osh/OSHRelationImpl.java
Outdated
Show resolved
Hide resolved
oshdb/src/main/java/org/heigit/ohsome/oshdb/impl/osh/OSHWayImpl.java
Outdated
Show resolved
Hide resolved
oshdb/src/main/java/org/heigit/ohsome/oshdb/util/bytearray/ByteArrayOutputWrapper.java
Outdated
Show resolved
Hide resolved
oshdb/src/main/java/org/heigit/ohsome/oshdb/util/bytearray/ByteArrayWrapper.java
Outdated
Show resolved
Hide resolved
oshdb/src/main/java/org/heigit/ohsome/oshdb/util/bytearray/ByteArrayWrapper.java
Show resolved
Hide resolved
tyrasd
added
the
breaking
This will introduce an incombability to previous versions. Documentation update compulsory
label
May 17, 2021
tyrasd
previously approved these changes
May 17, 2021
tyrasd
previously approved these changes
May 17, 2021
tyrasd
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
This will introduce an incombability to previous versions. Documentation update compulsory
code quality
Related to our standards for 'good' code
dependencies
referes to one of our dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the crosby.binary osm pbf implementation from our repository and replace them with a dependency to:
It also removes the dependency to google protobuf from the
oshdb
module. Because we only used the varint encoding from that library and this encoding is a standard, so we provide our own implementation for that.Corresponding issue
Closes #269, #295
New or changed dependencies
Checklist
I have made corresponding changes to the documentationI have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repository