Bug/#427 make iterate by contribute more streamable, replace filter with takewhile #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtroilo
changed the title
rtroilo
changed the title
tyrasd
reviewed
Sep 9, 2021
oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/mapreducer/backend/Kernels.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/main/java/org/heigit/ohsome/oshdb/util/celliterator/CellIterator.java
Show resolved
Hide resolved
oshdb-util/src/main/java/org/heigit/ohsome/oshdb/util/celliterator/CellIterator.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/main/java/org/heigit/ohsome/oshdb/util/celliterator/CellIterator.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/main/java/org/heigit/ohsome/oshdb/util/celliterator/CellIterator.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/main/java/org/heigit/ohsome/oshdb/util/celliterator/CellIterator.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/main/java/org/heigit/ohsome/oshdb/util/celliterator/CellIterator.java
Show resolved
Hide resolved
rtroilo
force-pushed
the
bug/#427_make_iterateByContribute_more_streamable_replace_filter_with_takewhile
branch
2 times, most recently
from
0ee81eb
to
8c7af5f
Compare
tyrasd
reviewed
Sep 13, 2021
Done. I also create a new Issue #429 for the snapshot view part as well. |
tyrasd
previously approved these changes
Sep 15, 2021
breaking for-loop up into iterator opening up iterateBy to accept Iterables instead of GridOSHEntity
tyrasd
force-pushed
the
bug/#427_make_iterateByContribute_more_streamable_replace_filter_with_takewhile
branch
from
5f00924
to
17c0155
Compare
tyrasd
approved these changes
Sep 15, 2021
tyrasd
deleted the
bug/#427_make_iterateByContribute_more_streamable_replace_filter_with_takewhile
branch
tyrasd
pushed a commit
that referenced
this pull request
Sep 16, 2021
breaking for-loop up into iterator opening up iterateBy to accept Iterables instead of GridOSHEntity replace filter with takeWhile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for Issue #427
Task keep processing for a while despite it is canceled.
Description
Replacing/refactoring the for-loop in CellIterator
iterateByContribution, to an Iterator which could be stream.The previous approach with a for-loop keeps generating all Contributions for an OSHEntity, collecting those into an LinkedList and finally streams the list "out" of the method
iterateByContribution.The new version skips the collecting of all Contributions to a LinkedList completely, that has the advantage,
Corresponding issue
Closes #427
Checklist
I have made corresponding changes to the documentationI have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repository