Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getRawRoleId and replace it with OSHDBRole #453

Merged
merged 9 commits into from
Apr 26, 2022
Merged

Conversation

rtroilo
Copy link
Member

@rtroilo rtroilo commented Apr 26, 2022

Make use of more meaningful representation of a role. User OSHDBRole instead of int.

Corresponding issue

Closes #

New or changed dependencies

  • removes OSMMember.getRawRoleId

Checklist

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

@rtroilo rtroilo requested a review from joker234 April 26, 2022 10:44
CHANGELOG.md Outdated Show resolved Hide resolved
rtroilo and others added 4 commits April 26, 2022 17:39
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
@rtroilo rtroilo merged commit 0aef5fe into master Apr 26, 2022
@rtroilo rtroilo deleted the oshdbrole branch April 26, 2022 16:53
@joker234 joker234 added this to In progress in oshdb refactoring via automation Apr 27, 2022
@joker234 joker234 added this to the release 1.0 milestone Apr 27, 2022
@joker234 joker234 moved this from In progress to Done in oshdb refactoring Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants