Fix #236: Show fitting error message if OQT response is not a valid JSON #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
previously approved these changes
Apr 5, 2023
There was a problem hiding this comment.
@mhhd2020 Please have a look at my comment and decide if you want to consider a different approach before merging it.
@matthiasschaub Thanks for the suggestion, that's indeed a good idea - I changed the OQT client accordingly |
matthiasschaub
approved these changes
Apr 18, 2023
mhhd2020
deleted the
236-unclear-error-message-is-shown-for-quality-analyses-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.