Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #207: Limit the max. number of uploaded files #248

Merged
merged 10 commits into from
Jul 5, 2023

Conversation

mhhd2020
Copy link
Contributor

As we once defined 80 uploads per user as upper boundary of what should be sufficient for the vast majority of uses, I set a value slightly above that (100). In case one needs more, one can of course always split up the uploads and later merge the files in a GIS. As this value is, therefore, theoretically reasoned and should be valid for all instances of the tool, it is not included in the config. However, if you deem it sensible to set this value in the config, I can change it accordingly.

sketch_map_tool/routes.py Outdated Show resolved Hide resolved
sketch_map_tool/routes.py Outdated Show resolved Hide resolved
@matthiasschaub
Copy link
Collaborator

Is it possible to write a test case for this?

@mhhd2020
Copy link
Contributor Author

Is it possible to write a test case for this?

Yes and Done

Copy link
Collaborator

@matthiasschaub matthiasschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some suggestions regarding tests, otherwise fine :)

@mhhd2020 mhhd2020 force-pushed the 207-restrict-number-of-images-during-upload-handling branch from 849919f to b078b0a Compare July 3, 2023 16:20
@mhhd2020 mhhd2020 dismissed matthiasschaub’s stale review July 3, 2023 16:35

Implemented changes

@mhhd2020 mhhd2020 merged commit 723dc18 into main Jul 5, 2023
2 checks passed
@mhhd2020 mhhd2020 deleted the 207-restrict-number-of-images-during-upload-handling branch July 5, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict number of images during upload handling
2 participants