212 Create the scale bar directly in reportlab to solve the sigkill 9 error during the creation of multiple A0 sketch maps #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhhd2020
added
bug
|
Tested for all paper formats in both landscape and portrait mode as well as for both large and small areas of interest Example for A4: |
mhhd2020
changed the title
matthiasschaub
previously requested changes
Jul 5, 2023
mhhd2020
force-pushed
the
212-create-sketch-map-in-a0-fails-worker-exited-prematurely-signal-9-sigkill-job-4
branch
from
9765ee9
to
fbb9a20
Compare
matthiasschaub
previously approved these changes
Jul 5, 2023
…rameters for conformity with old version
mhhd2020
force-pushed
the
212-create-sketch-map-in-a0-fails-worker-exited-prematurely-signal-9-sigkill-job-4
branch
from
fbb9a20
to
b8d9a76
Compare
matthiasschaub
approved these changes
Jul 12, 2023
mhhd2020
deleted the
212-create-sketch-map-in-a0-fails-worker-exited-prematurely-signal-9-sigkill-job-4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiments have shown that the problem when simultaneously creating multiple A0 sketch maps likely is the use of matplotlib to add a scale bar to the map frames. Loading the map image in matplotlib seems to consume too much RAM (if multiple A0 maps are created), leading to the issue #212.
Therefore, the function
add_scalebar(...)has been rewritten to directly add the scalebar on the canvas in reportlab. Creating 10 A0 sketch maps at the same time, which has previously been impossible, now works without problems on the local instance.