feat(sketch-map): add attributions file #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
requested changes
Feb 13, 2024
matthiasschaub
requested changes
Feb 19, 2024
sketch_map_tool/tasks.py
Outdated
| # r = interim result | ||
| r = db_client_celery.select_file(sketch_map_id) | ||
| r = to_array(r) | ||
| r = clip(r, map_frames[uuid]) | ||
| r = georeference(r, bbox) | ||
| return r | ||
|
|
||
| def get_attribution_text(layer: Layer) -> BytesIO: |
There was a problem hiding this comment.
Suggested change
| def get_attribution_text(layer: Layer) -> BytesIO: | |
| def get_attribution_file(layer: Layer) -> BytesIO: |
sketch_map_tool/tasks.py
Outdated
Comment on lines
126
to
128
| for layer in layers: | ||
| with ZipFile(buffer, "a") as zip_file: | ||
| zip_file.writestr("attributions.txt", get_attribution_text(layer).read()) |
There was a problem hiding this comment.
I would move the iteration through the layers to get_attribution_text. -> Write just a single attributions.txt with all attributions in it.
The way it is currently implemented, it would overwrite attibutions.txt in the case of multiple layers.
matthiasschaub
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #371