Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #195 #196

Merged
merged 1 commit into from
Mar 14, 2016
Merged

fixes #195 #196

merged 1 commit into from
Mar 14, 2016

Conversation

jordansread
Copy link
Member

@lawinslow take a look?

@@ -3,6 +3,7 @@
#'@param var_name a character vector of valid variable names (see \code{\link{sim_vars}})
#'@param fig_path F if plot to screen, string path if save plot as .png
#'@param reference 'surface' or 'bottom'. Only used for heatmap plots.
#' @param col_lim range for heatmap (in units of the variable)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start using param inheriting on this package at some point.

@lawinslow
Copy link
Member

Looks good.
Side note, we may want to point travis install of GLMr to GRAN so we don't get these annoying failures.

lawinslow pushed a commit that referenced this pull request Mar 14, 2016
@lawinslow lawinslow merged commit cdb32fa into GLEON:master Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants