Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory usage improvements #237

Merged
merged 11 commits into from Sep 2, 2022
Merged

Memory usage improvements #237

merged 11 commits into from Sep 2, 2022

Conversation

publixsubfan
Copy link
Contributor

@publixsubfan publixsubfan commented Aug 19, 2022

Summary

  • Defer buffering objects to the GPU until they're actually used in a pending frame
  • Use indexed buffers to hold ordering curve
  • Don't draw cones when cone_scale is 0 (PrepareOrderingCurves() uses Arrow3 to draw the no-arrow curve)

With these changes, I get around 0.97GB of memory usage for the command in #236, which puts us almost at where we were at version glvis-4.0.

Things to try:

  • Remove second texture coordinate - this should drop us down from 32 to 16 bytes/vertex when storing VertexTex due to alignment
  • Defer generation of element/vertex/edge numberings until they're toggled on - now 0.72GB

@publixsubfan publixsubfan marked this pull request as ready for review August 25, 2022 17:50
@tzanio
Copy link
Member

tzanio commented Aug 25, 2022

@kanye-quest, the current failure is not due to that, but you probably want to merge master for its macos CI fixes

@tzanio
Copy link
Member

tzanio commented Aug 26, 2022

  • Should we mention it in CHANGELOG? -- done in 5b54bee

@tzanio
Copy link
Member

tzanio commented Aug 31, 2022

@v-dobrev and @tomstitt -- can you please review when you get a chance?

Copy link
Member

@tomstitt tomstitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @kanye-quest !!

@tzanio tzanio merged commit 95d29b7 into master Sep 2, 2022
@tzanio tzanio deleted the memory-usage-dev branch September 2, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants