Barrier check #1788
Merged
Barrier check #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@nightlark I think this is ready for review. I think I have an idea on the failing app tests, but that needs to go in a separate PR. |
nightlark
approved these changes
Mar 20, 2021
phlptp
added a commit
that referenced
this pull request
Apr 6, 2021
* try to fix a bug in the time barrier clear operation * rework the minFed check for timing * Automated formatting of repo files (#1789) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix clang tidy issues
phlptp
added a commit
that referenced
this pull request
Apr 9, 2021
* Messages on init. (#1717) * Tests and some fixes for getting messages in initialization mode on iteration * Automated formatting of repo files (#1718) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * add additional test * fix timing bug on local federates * Automated formatting of repo files (#1720) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * fix clang-tidy issue * Automated formatting of repo files (#1722) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * add some capabilities to the dependency management * more tweaks to the time control for ForwardingTimeCoordinator and associated operations * add update back in * some more tweaks for timing tests * make sure the halted time is consistent * make sure the halted time is consistent * update more tests * make the callback locked for endpoint callbacks * fix the echo test and possible inconsistencies in message delivery * try cleaning up a few more tests * add some more tests to echo tests * try a slightly different minimum modification * Try some additional conditions on the Forwarding time coordinators * try another tactic for generating the min federate * try another tactic for generating the min federate * add some delay capability to test comms and some other test function in the forwarding time coordinator * start moving the filters to a separate federate * updates to code for archival * Work out details in FilterFederate and time coordinators * Fix 5 message tests * pass the iteration tests * fix restricted time policy code again * fix compile errors * Try changing the destructor for FilterFederate * fix uninitialized value * more sanitizer fixes * Fix cppcheck issues * add some debugging output for deadlocks on iteration tests * try adjusting when messages get sent * add some time to checks and add boost 1.75 inclusion * Automated formatting of repo files (#1737) * add boost to pipelines * Automated formatting of repo files Co-authored-by: Philip Top <phlptp@gmail.com> Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * add some delays in recorder * Apply suggestions from code review Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> * Fix offset timing bug (#1759) * Fix offset timing bug * Automated formatting of repo files (#1760) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * Barrier check (#1788) * try to fix a bug in the time barrier clear operation * rework the minFed check for timing * Automated formatting of repo files (#1789) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix clang tidy issues * message required destinations (#1755) * fix some warnings and make it possible to set default for messages to be required to have a destination * Automated formatting of repo files (#1756) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * fix clan tidy issues * add the option of ordered queries (#1793) * add the option of ordered queries which are slower but have more guarantees of order since they travel on the normal priority paths * Automated formatting of repo files [skip ci] (#1794) * Install Boost for Windows GitHub Actions Workflows (#1790) * Install Boost 1.74 for Windows release build packaging and benchmark installer GitHub Actions workflows * Comment and minor clean-up of the scripts used for the Windows GHA workflows * Automated formatting of repo files Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> * update the new command names * Automated formatting of repo files (#1795) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> * add ordering argument to brokerApp query calls * Automated formatting of repo files (#1796) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix bug causing an overwritten flag * Automated formatting of repo files (#1800) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> * Event triggered flag (#1804) * Add an event triggered flag for timing, mainly for filters but can be used elsewhere. * make some fixes for recorder and echo * fix clang-tidy warnings * shift the clone tests and more clang-tidy fixes * add flag string translation support * Automated formatting of repo files (#1805) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add delay to clone queries * add delay to clone queries * Automated formatting of repo files (#1806) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix potential deadlock related to query changes * Automated formatting of repo files (#1807) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix clone tests * Automated formatting of repo files (#1808) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add query_reply_ordered * Automated formatting of repo files (#1809) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix time coordinator undefined behavior possibilities * Automated formatting of repo files (#1810) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix a test that was failing under the no-zmq condition (#1812) * Fix a test that was failing under the no-zmq condition * Automated formatting of repo files (#1813) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * now compiling * all tests passing * Automated formatting of repo files (#1821) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * update queryMode style * update the helics.h backup files * Automated formatting of repo files (#1822) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will add a few checks to the barrier clear operation and fix a potential issue with the timings.
also resolve some Msan failures from previous merges.
Attempt to resolve #1750