Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging feature boundaries not working as expected for Shine-Dalgarno and CDS #2515

Closed
MoffMade opened this issue Sep 24, 2020 · 10 comments · Fixed by #2516
Closed

Dragging feature boundaries not working as expected for Shine-Dalgarno and CDS #2515

MoffMade opened this issue Sep 24, 2020 · 10 comments · Fixed by #2516
Projects

Comments

@MoffMade
Copy link
Collaborator

MoffMade commented Sep 24, 2020

We're experiencing some issues dragging the boundaries on gene annotations called from evidence with both a Shine-Dalgarno_sequence and a CDS.

  • Gene with SD+CDS
    • Shine Dalgarno boundary
      • Away from CDS > New Shine Dalgarno is created at new boundary separate from original gene feature
      • Towards CDS > Nothing, no logs
    • CDS Boundary, nothing happens either way, error popup in UI with "Cannot get property 'id' on null object" and gets this error in logs
ERROR apollo.AnnotationEditorController  - CAUGHT ERROR through websocket call: java.lang.reflect.InvocationTargetException
ERROR apollo.AnnotationEditorController  - THROWING PARENT ERROR instead through reflection: java.lang.NullPointerException: Cannot get property 'id' on null object
ERROR apollo.AnnotationEditorController  - exception java.lang.NullPointerException: Cannot get property 'id' on null object
ERROR apollo.AnnotationEditorController  - exception message Cannot get property 'id' on null object
ERROR apollo.AnnotationEditorController  - username cory.maughmer@tamu.edu
ERROR apollo.AnnotationEditorController  - error destination message: /topic/AnnotationNotification/user/cory.maughmer@tamu.edu
  • Gene with no SD, only CDS works as expected
  • tRNA and terminator boundaries drag as expected

Screenshot of error:
Screenshot from 2020-09-23 13-04-27

This same error message appears when attempting to "split" a gene with both SD and CDS

@nathandunn
Copy link
Contributor

Can you right-click on the annotation and add the GFF3 for all components in there?

@nathandunn nathandunn added this to To do in 2.6.2 LTS via automation Sep 24, 2020
@nathandunn nathandunn moved this from To do to In progress in 2.6.2 LTS Sep 24, 2020
@MoffMade
Copy link
Collaborator Author

##gff-version 3
##sequence-region ACHIV102_cov_229.2 1 42452
ACHIV102_cov_229.2	.	gene	32061	32519	.	+	.	owner=meiliu@tamu.edu,cory.maughmer@tamu.edu;ID=1b3e7cb5-bb0a-4ce3-aaf7-367c2a51bdfa;date_last_modified=2020-09-23;Name=ACHIV102_cov_229.2.orf00066;date_creation=2020-09-01
ACHIV102_cov_229.2	.	mRNA	32061	32519	.	+	.	owner=cory.maughmer@tamu.edu;Parent=1b3e7cb5-bb0a-4ce3-aaf7-367c2a51bdfa;ID=f3831d22-8c02-4524-ad1d-2f1965e87696;orig_id=ACHIV102_cov_229.2.orf00066;date_last_modified=2020-09-23;Name=ACHIV102_cov_229.2.orf00066-00002;date_creation=2020-09-23
ACHIV102_cov_229.2	.	exon	32073	32519	.	+	.	Parent=f3831d22-8c02-4524-ad1d-2f1965e87696;ID=ea90c5ba-3525-4566-83f0-6b419b344e99;Name=ea90c5ba-3525-4566-83f0-6b419b344e99
ACHIV102_cov_229.2	.	CDS	32073	32519	.	+	0	Parent=f3831d22-8c02-4524-ad1d-2f1965e87696;ID=f3831d22-8c02-4524-ad1d-2f1965e87696-CDS;Name=f3831d22-8c02-4524-ad1d-2f1965e87696-CDS
ACHIV102_cov_229.2	.	Shine_Dalgarno_sequence	32061	32068	.	+	.	Parent=f3831d22-8c02-4524-ad1d-2f1965e87696;ID=0bdce2de-0d43-4ec3-a149-51b4cc60dad3;Name=0bdce2de-0d43-4ec3-a149-51b4cc60dad3
###

This is the GFF for the specific example in the screenshot but it's happening across most organisms we've created since the update to 2.6.1

@nathandunn
Copy link
Contributor

@MoffMade I'm not seeing it initially, but I'm sure I don't have the same setup.

Can you email me a tarball of the jbrowse directory you are using so I can emulate it. If you could also indicate from which track and how you generated the annotation, that would be helpful.

I'm assuming you are running off of the latest.

@MoffMade
Copy link
Collaborator Author

Sure thing, let me pull it and I'll send it your way. We're running a fork of 2.6.1 with a couple of docker changes and css modifications.

This issue is occurring on features promoted to gene annotations from any of the tracks that have both a Shine-Dalgarno and a Exon/CDS

@nathandunn
Copy link
Contributor

Should be noted that the GFF3 I get is fairly similar, with nothing of note incorrect:

##gff-version 3
##sequence-region ACHIV102_cov_229.2 1 42452
ACHIV102_cov_229.2	testing	gene	20958	22306	.	+	.	owner=ndunn@me.com;ID=40b1041e-fe11-4d43-85a9-f4001dfbfbe9;date_last_modified=2020-09-25;Name=ACHIV102_cov_229.2.orf00043;date_creation=2020-09-25
ACHIV102_cov_229.2	testing	mRNA	20958	22306	.	+	.	owner=ndunn@me.com;Parent=40b1041e-fe11-4d43-85a9-f4001dfbfbe9;ID=229784f8-0098-4af6-b54c-db4e1b0b7082;orig_id=ACHIV102_cov_229.2.orf00043;date_last_modified=2020-09-25;Name=ACHIV102_cov_229.2.orf00043-00001;date_creation=2020-09-25
ACHIV102_cov_229.2	testing	exon	20969	22306	.	+	.	Parent=229784f8-0098-4af6-b54c-db4e1b0b7082;ID=c1101238-04fe-4742-8f98-2139e0e9d272;Name=c1101238-04fe-4742-8f98-2139e0e9d272
ACHIV102_cov_229.2	testing	Shine_Dalgarno_sequence	20956	20960	.	+	.	Parent=229784f8-0098-4af6-b54c-db4e1b0b7082;ID=5aa0b906-84fb-4dd3-982c-0d8d94a133db;Name=5aa0b906-84fb-4dd3-982c-0d8d94a133db
ACHIV102_cov_229.2	testing	non_canonical_three_prime_splice_site	20969	20969	.	+	.	Parent=229784f8-0098-4af6-b54c-db4e1b0b7082;ID=229784f8-0098-4af6-b54c-db4e1b0b7082-non_canonical_three_prime_splice_site-20968;Name=229784f8-0098-4af6-b54c-db4e1b0b7082-non_canonical_three_prime_splice_site-20968
ACHIV102_cov_229.2	testing	CDS	20969	22306	.	+	0	Parent=229784f8-0098-4af6-b54c-db4e1b0b7082;ID=229784f8-0098-4af6-b54c-db4e1b0b7082-CDS;Name=229784f8-0098-4af6-b54c-db4e1b0b7082-CDS
###

However, when I look at the child / parent feature relationship for the exon being edited, the parent is also the same exon . . .

parent Feature{id=612, symbol='null', description='null', name='c1101238-04fe-4742-8f98-2139e0e9d272', uniqueName='c1101238-04fe-4742-8f98-2139e0e9d272', sequenceLength=null, status=null, dateCreated=2020-09-25 18:37:25.707, lastUpdated=2020-09-25 18:37:25.949} -> SO:0000147 -> exon
child Feature{id=614, symbol='null', description='null', name='bcaf9c39-d35f-40ff-a874-4b738f4173c5', uniqueName='bcaf9c39-d35f-40ff-a874-4b738f4173c5', sequenceLength=null, status=null, dateCreated=2020-09-25 18:37:25.701, lastUpdated=2020-09-25 18:37:25.949} -> SO:0000147 -> exon

for child feature relationships of feature:

input exon Feature{id=614, symbol='null', description='null', name='bcaf9c39-d35f-40ff-a874-4b738f4173c5', uniqueName='bcaf9c39-d35f-40ff-a874-4b738f4173c5', sequenceLength=null, status=null, dateCreated=2020-09-25 18:37:25.701, lastUpdated=2020-09-25 18:37:25.949}

@nathandunn
Copy link
Contributor

However, the `bcaf...' does not show up in the GFF3.

@nathandunn
Copy link
Contributor

So, the issue is that it goes from gene -> mRNA -> exon -> exon . . . I'm not sure why its creating the second exon or why it was created at that level.

I actually removed most of the Shine Dalgarno code because there were some implementation issues, so its surprising it is working at all. I actually thought we were going to wait on this implementation, but its possible that we can work around this, as well.

@nathandunn
Copy link
Contributor

So, the issue here is to fix this by:

  1. eliminate the creation of the extra exon
  2. suppress calculation

@nathandunn
Copy link
Contributor

@MoffMade This does work for HTMLFeatures:

image

##gff-version 3
##sequence-region ACHIV102_cov_229.2 1 42452
ACHIV102_cov_229.2	testing	gene	20958	22306	.	+	.	owner=ndunn@me.com;ID=d883d2c6-28be-400d-85b5-5ca7fffaab87;date_last_modified=2020-09-28;Name=ACHIV102_cov_229.2;date_creation=2020-09-28
ACHIV102_cov_229.2	testing	mRNA	20958	22306	.	+	.	owner=ndunn@me.com;Parent=d883d2c6-28be-400d-85b5-5ca7fffaab87;ID=9d8d5fbc-289e-4ecd-8200-0bd1140b9e86;date_last_modified=2020-09-28;Name=ACHIV102_cov_229.2-00001;date_creation=2020-09-28
ACHIV102_cov_229.2	testing	exon	20974	22306	.	+	.	Parent=9d8d5fbc-289e-4ecd-8200-0bd1140b9e86;ID=5a0aee2a-73a2-4c99-8acd-554a8f8fd468;Name=5a0aee2a-73a2-4c99-8acd-554a8f8fd468
ACHIV102_cov_229.2	testing	non_canonical_three_prime_splice_site	20974	20974	.	+	.	Parent=9d8d5fbc-289e-4ecd-8200-0bd1140b9e86;ID=9d8d5fbc-289e-4ecd-8200-0bd1140b9e86-non_canonical_three_prime_splice_site-20973;Name=9d8d5fbc-289e-4ecd-8200-0bd1140b9e86-non_canonical_three_prime_splice_site-20973
ACHIV102_cov_229.2	testing	Shine_Dalgarno_sequence	20958	20960	.	+	.	Parent=9d8d5fbc-289e-4ecd-8200-0bd1140b9e86;ID=dc8259d4-33d6-4212-aceb-6261b540d383;Name=dc8259d4-33d6-4212-aceb-6261b540d383
ACHIV102_cov_229.2	testing	CDS	20975	22306	.	+	0	Parent=9d8d5fbc-289e-4ecd-8200-0bd1140b9e86;ID=9d8d5fbc-289e-4ecd-8200-0bd1140b9e86-CDS;Name=9d8d5fbc-289e-4ecd-8200-0bd1140b9e86-CDS
###

@nathandunn
Copy link
Contributor

nathandunn commented Sep 28, 2020

You have to drag them up at the same time, and then it works as expected. I think the fix for this is multiple fold.

  1. implement https://github.com/GMOD/Apollo/pull/2143/files to incorproate shine dalgarno explicitly (and include some other things) - which was reverted at some later point
  2. fix addition of Shine Dalgarno Canvas track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2.6.2 LTS
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants