Downgrades certain NSAssert uses to a conditional log

Summary:
We had a few buggy uses of NSAssert in the codebase, where what we really
wanted was a conditional log, in order to send the signal to a developer that
something may be amiss; but for which throwing an exception would be the
wrong remedy.

Test Plan: introduced unit test to test new logging macro, ran tests

Reviewers: clang, mmarucheck, gregschechte

Reviewed By: clang

CC: msdkexp@, platform-diffs@lists

Differential Revision: https://phabricator.fb.com/D546960

Task ID: 1368595

src/FBGraphObjectTableDataSource.m

@@ -71,8 +71,8 @@ - (id)init
 
 - (void)dealloc
 {
-    NSAssert(![_pendingURLConnections count],
-             @"FBGraphObjectTableDataSource pending connection did not retain self");
+    FBConditionalLog(![_pendingURLConnections count],
+                     @"FBGraphObjectTableDataSource pending connection did not retain self");
 
     [_data release];
     [_defaultPicture release];

src/FBLogger.m

@@ -185,8 +185,8 @@ + (void)registerCurrentTime:(NSString *)loggingBehavior
             g_startTimesWithTags = [[NSMutableDictionary alloc] init];
         }
 
-        NSAssert(g_startTimesWithTags.count < 1000,
-                 @"Unexpectedly large number of outstanding perf logging start times, something is likely wrong.");
+        FBConditionalLog(g_startTimesWithTags.count < 1000,
+                         @"Unexpectedly large number of outstanding perf logging start times, something is likely wrong.");
 
         unsigned long currTime = [FBUtility currentTimeInMilliseconds];
 

src/FBProfilePictureView.m

@@ -17,6 +17,7 @@
 #import "FBProfilePictureView.h"
 #import "FBURLConnection.h"
 #import "FBRequest.h"
+#import "FBUtility.h"
 
 @interface FBProfilePictureView()
 
@@ -155,7 +156,7 @@ - (void)refreshImage:(BOOL)forceRefresh  {
 
         FBURLConnectionHandler handler = 
             ^(FBURLConnection *connection, NSError *error, NSURLResponse *response, NSData *data) {
-                NSAssert(self.connection == connection, @"Inconsistent connection state");
+                FBConditionalLog(self.connection == connection, @"Inconsistent connection state");
 
                 self.connection = nil;
                 if (!error) {

src/FBSession.m

@@ -394,7 +394,7 @@ - (BOOL)handleOpenURL:(NSURL *)url {
             return [self handleOpenURLReauthorize:params
                                       accessToken:accessToken];
         default:
-            NSAssert(NO, @"handleOpenURL should not be called once a session has closed");
+            FBConditionalLog(NO, @"handleOpenURL should not be called once a session has closed");
             return NO;
     }
 }

src/FBUtility.h

@@ -39,7 +39,15 @@
                            inBundle:(NSBundle *)bundle;
 
 @end
-
+
+#define FBConditionalLog(condition, desc, ...) \
+do { \
+    if (!(condition)) {	\
+        NSString *msg = [NSString stringWithFormat:(desc), ##__VA_ARGS__]; \
+        NSLog(@"FBConditionalLog: %@", msg); \
+    } \
+} while(NO)
+
 #define FB_BASE_URL @"facebook.com"
 
 

src/tests/FBSessionTests.m

@@ -20,6 +20,7 @@
 #import "FBGraphUser.h"
 #import "FBTestBlocker.h"
 #import "FBTests.h"
+#import "FBUtility.h"
 
 #if defined(FACEBOOKSDK_SKIP_SESSION_TESTS)
 
@@ -32,6 +33,10 @@ @implementation FBSessionTests
 // All code under test must be linked into the Unit Test bundle
 - (void)testSessionBasic
 {
+    FBConditionalLog(NO, @"Testing conditional %@", @"log");
+    FBConditionalLog(NO, @"Testing conditional log");
+    FBConditionalLog(YES, nil, @"Testing conditional log");
+
     // create valid
     FBTestBlocker *blocker = [[[FBTestBlocker alloc] init] autorelease];