Implement natural sort for thumbnails in MediaPage #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses bug #717960, "Natural sorting of photo titles" I grafted NaturalSort.vala from my own https://github.com/tobiatesan/NaturalCmp Please find the ticket at: https://bugzilla.gnome.org/show_bug.cgi?id=717960
tobiatesan
force-pushed
the
natural_sort
branch
from
13b1605
to
5bb6c30
Compare
Just to be really sure. Especially to rule out weird things happening with non-arabic numerals.
The experienced behaviour is in fact correct, since "十" nor any other Chinese numeral is considered a numeral by isdigit(), which only cares about alternate /glyphs/ for the plain old decimal/arabic system. The Chinese numbering system has its own composition rules (e.g. "2" is written "二" - i.e. two horizontal strokes, "1" is written "一" - i.e. single horizontal stroke, but "21" is not written "二一").
|
The code seems merged. Can you please close this PR? I cannot. |
|
Thank you for contributing to shotwell! shotwell uses Bugzilla for code review. If you have never contributed to GNOME before make sure you have read the Otherwise please visit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses bug #717960.
(But beware: I'm still getting my feet wet with Vala - coming from C++ - and Shotwell, so it can be likely ugly and/or not
very Vala-idiomatic. Please do voice any concerns.)