Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate: why is UCERF3 code called #241

Closed
chrisdicaprio opened this issue May 9, 2022 · 1 comment
Closed

Investigate: why is UCERF3 code called #241

chrisdicaprio opened this issue May 9, 2022 · 1 comment
Assignees
@voj

Comments

@chrisdicaprio
Copy link
Contributor

why is UCERF3InversionConfiguration.getSmoothStartingSolution being called? Is it necessary?

We'd like to avoid calling, if possible, since the NZ inversions require a code change to this method that cannot be merged on the upstream fork
@voj
Copy link
Collaborator

voj commented May 12, 2022

History:

  • the call has been there from the first version of the file
  • it was simply commented out for a while 8794202
  • and then restored a few months later a876e89

This commit has this comment for adjustStartingModel:

 * CBC: cloned this from UCERF3InversionConfiguration just for testing with some water levels. It needs work to  
 * decided a) if its wanted and b) how it should work!! @MCG

@voj voj mentioned this issue Mar 7, 2024
Closed
@voj voj closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voj voj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@voj @chrisdicaprio