Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server should make a bigger part of the import #1156

Closed
julien-duponchelle opened this issue Apr 4, 2016 · 1 comment
Closed

Server should make a bigger part of the import #1156

julien-duponchelle opened this issue Apr 4, 2016 · 1 comment
Assignees
@julien-duponchelle
Labels
Enhancement
Milestone
1.5

Comments

@julien-duponchelle
Copy link
Contributor

After reflexion before shipping 1.5 I want to move a part of this:
https://github.com/GNS3/gns3-gui/blob/1.5/gns3/utils/import_project_worker.py#L63

To the server to make it easy to port for 2.0 and easier support for solving issue raise by #1151.

The server should receive, the zip, a project directory and the name of the .gns3.

  • After that the server uncompress the zip
  • Change the project uuid
  • Rename project.gns3

Not a big refactor.
@julien-duponchelle julien-duponchelle self-assigned this Apr 4, 2016
@julien-duponchelle julien-duponchelle added this to the 1.5 milestone Apr 4, 2016
julien-duponchelle added a commit to GNS3/gns3-server that referenced this issue Apr 5, 2016
@julien-duponchelle
Move more import code to the server
9ed15e5 
GNS3/gns3-gui#1156
julien-duponchelle added a commit that referenced this issue Apr 5, 2016
@julien-duponchelle
Server make a bigger part of the import
a38a8c4 
Fix #1156
@julien-duponchelle
Copy link
Contributor Author

Much cleaner and better tested :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julien-duponchelle julien-duponchelle

Labels
Enhancement
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
1 participant
@julien-duponchelle