Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to choose if we want to auto close the project or not #1331

Closed
julien-duponchelle opened this issue Jun 23, 2016 · 2 comments
Closed

Allow to choose if we want to auto close the project or not #1331

julien-duponchelle opened this issue Jun 23, 2016 · 2 comments
Assignees
@julien-duponchelle
Labels
Enhancement
Milestone
2.0.1

Comments

@julien-duponchelle
Copy link
Contributor

Actually when a GUI close or change project the GUI close the project. Previously this was handle by a count on how many GUI listen for project notification but it's not easy to do with web interface (user can reload a page) and it's doesn't cover all cases.

Because we want to allow connecting to open project #1251 we need a way to keep them open

Proposal

  • When I open a project I have a checkbox asking if I want to close the project when I change project
  • When I connect to a running project this not enable
  • In the project menu we have a checkbox allowing us to change this behavior (we can add to this menu also the delete project menu)
    image
@julien-duponchelle julien-duponchelle added this to the 2.0 milestone Jun 23, 2016
@grossmj
Copy link
Member

grossmj commented Aug 2, 2016

Like that. I would name the option: "Leave this project open when closing GNS3" or something similar.

@julien-duponchelle julien-duponchelle mentioned this issue Aug 2, 2016
Closed
@julien-duponchelle julien-duponchelle self-assigned this Aug 15, 2016
@julien-duponchelle
Copy link
Contributor Author

The edit project dialog with all options:
image

julien-duponchelle added a commit to GNS3/gns3-server that referenced this issue Aug 16, 2016
@julien-duponchelle
Option for auto close project when no client listen
9694850 
And fix websocket not correctly detected has closed.

Ref GNS3/gns3-gui#1331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julien-duponchelle julien-duponchelle

Labels
Enhancement
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
2 participants
@julien-duponchelle @grossmj