Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support symbol themes #1466

Open
grossmj opened this issue May 8, 2018 · 4 comments
Open

Support symbol themes #1466

grossmj opened this issue May 8, 2018 · 4 comments
Assignees
@grossmj
Labels
Enhancement Refactor
Milestone
3.1

Comments

@grossmj
Copy link
Member

grossmj commented May 8, 2018

https://gns3.com/discussions/new-symbols
@grossmj grossmj self-assigned this May 8, 2018
@grossmj
Copy link
Member Author

grossmj commented Jun 9, 2018

New location for the symbols: https://github.com/ecceman/affinity

grossmj referenced this issue Aug 12, 2018
@grossmj
Add affinity symbols. Ref https://github.com/GNS3/gns3-gui/issues/2488
29620f4
@grossmj
Copy link
Member Author

grossmj commented Aug 12, 2018

Need to come up with a strategy to handle symbol sets and symbol management in general.

@grossmj grossmj transferred this issue from GNS3/gns3-gui Nov 24, 2018
@grossmj grossmj added this to the 2.2 milestone Nov 24, 2018
@grossmj grossmj changed the title Support symbols set Support symbol themes Nov 24, 2018
grossmj added a commit that referenced this issue Nov 27, 2018
@grossmj
Merge pull request #1467 from GNS3/symbol-themes
b4a2bc5 
Support symbol themes. Ref #1466
@grossmj
Copy link
Member Author

grossmj commented Nov 27, 2018 •
edited

Only a few things left:

  • Support API endpoints to get/add/update/delete symbol themes and one to select the theme to be used (should probably add this on a per project basis).

  • GUI support to list themes and select one.

  • Review default fonts to check if they go well with our builtin symbol themes.

  • Builtin nodes to use symbol themes.

@grossmj
Copy link
Member Author

grossmj commented Mar 12, 2019

I have implemented an early symbol theme support. It is only used when listing appliances from a server. Depending on user feedback, a more advanced support could be done in 2.3 for instance.

@grossmj grossmj modified the milestones: 2.2, 2.3 Mar 12, 2019
@grossmj grossmj modified the milestones: 2.3, 2.4 Sep 27, 2019
@piotrpekala7 piotrpekala7 mentioned this issue Nov 5, 2019
Closed
@grossmj grossmj modified the milestones: 2.4, 3.0 Mar 11, 2020
@grossmj grossmj modified the milestones: 3.0, 3.1 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grossmj grossmj

Labels
Enhancement Refactor
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
1 participant
@grossmj