Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage text to device template #829

Closed
ghost opened this issue Nov 17, 2015 · 5 comments
Closed

Add usage text to device template #829

ghost opened this issue Nov 17, 2015 · 5 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Nov 17, 2015

When importing a GNS3 appliance an usage text will be shown (when included in the appliance).

It would be helpful when this usage text can be viewed later. Therefore I suggest to copy this usage text to the device template. Then this usage text can be shown, when hovering over a device of this type.

@julien-duponchelle
Copy link
Contributor

Seem to be a good idea for 1.4 or a later release.

@grossmj
Copy link
Member

grossmj commented Nov 30, 2015

👍

@julien-duponchelle julien-duponchelle self-assigned this Dec 1, 2015
julien-duponchelle added a commit to GNS3/gns3-server that referenced this issue Dec 1, 2015
@julien-duponchelle
Copy link
Contributor

Done in template and on hover, good idea

@ghost
Copy link
Author

ghost commented Dec 1, 2015

When saving or loading a project with usage I get a validation error:

{'process_priority': 'normal', 'mac_address': '00:00:ab:9a:f3:00', 'cpu_throttling': 0, 'acpi_shutdown': False, 'cpus': 1, 'qemu_path': '/usr/local/bin/qemu-system-i386', 'name': 'TinyCore-1', 'ram': 96, 'options': '-nographic', 'hdc_disk_interface': 'ide', 'hda_disk_image': 'linux-tinycore-6.4.img', 'boot_priority': 'c', 'hdb_disk_interface': 'ide', 'console_type': 'vnc', 'usage': 'Login is gns3/gns3. sudo works without password', 'adapters': 1, 'hda_disk_interface': 'ide', 'hda_disk_image_md5sum': 'e3de478780c0acb76ef92f872fe734c4', 'console': 5900, 'adapter_type': 'e1000', 'hdd_disk_interface': 'ide', 'platform': 'i386', 'legacy_networking': False} is not valid under any of the given schemas

Failed validating 'oneOf' in schema['properties']['topology']['properties']['nodes']['items']['properties']['properties']:
    {'oneOf': [{'$ref': '#/definitions/properties_vpcs'},
               {'$ref': '#/definitions/properties_dynamips'},
               {'$ref': '#/definitions/properties_dynamips_frame_relay'},
               {'$ref': '#/definitions/properties_qemu'},
               {'$ref': '#/definitions/properties_virtualbox'},
               {'$ref': '#/definitions/properties_vmware'},
               {'$ref': '#/definitions/properties_iou'},
               {'$ref': '#/definitions/properties_cloud_host'}],
     'type': 'object'}

On instance['topology']['nodes'][0]['properties']:
    {'acpi_shutdown': False,
     'adapter_type': 'e1000',
     'adapters': 1,
     'boot_priority': 'c',
     'console': 5900,
     'console_type': 'vnc',
     'cpu_throttling': 0,
     'cpus': 1,
     'hda_disk_image': 'linux-tinycore-6.4.img',
     'hda_disk_image_md5sum': 'e3de478780c0acb76ef92f872fe734c4',
     'hda_disk_interface': 'ide',
     'hdb_disk_interface': 'ide',
     'hdc_disk_interface': 'ide',
     'hdd_disk_interface': 'ide',
     'legacy_networking': False,
     'mac_address': '00:00:ab:9a:f3:00',
     'name': 'TinyCore-1',
     'options': '-nographic',
     'platform': 'i386',
     'process_priority': 'normal',
     'qemu_path': '/usr/local/bin/qemu-system-i386',
     'ram': 96,
     'usage': 'Login is gns3/gns3. sudo works without password'}

Validation error when dumping the topology.

Without the usage field, everything is fine. I assume gns3/schemas/topology.json has to be updated.

@julien-duponchelle
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants