Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gns3server.modules.iou.iou_vm in adapter_remove_nio_binding ProcessLookupError: [Errno 3] No such process #255

Closed
julien-duponchelle opened this issue Jul 7, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@julien-duponchelle
Copy link
Contributor

https://app.getsentry.com/gns3/gns3-server/group/59508315/

ProcessLookupError: [Errno 3] No such process
  File "gns3server/web/route.py", line 171, in control_schema
    yield from func(request, response)
  File "asyncio/tasks.py", line 84, in coro
    res = func(*args, **kw)
  File "gns3server/handlers/api/iou_handler.py", line 238, in delete_nio
    vm.adapter_remove_nio_binding(int(request.match_info["adapter_number"]), int(request.match_info["port_number"]))
  File "gns3server/modules/iou/iou_vm.py", line 897, in adapter_remove_nio_binding
    os.kill(self._iouyap_process.pid, signal.SIGHUP)
@grossmj
Copy link
Member

grossmj commented Jul 25, 2015

Don't understand how this is possible. We check that the process is alive before sending the SIGHUP signal... maybe checking returncode is not enough?

We can still catch the ProcessLookupError exception in last resort.

@julien-duponchelle
Copy link
Contributor Author

Perhaps a race condition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants