Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPUs and memory limitation for Docker containers #951

Closed
grossmj opened this issue Jul 31, 2020 · 6 comments
Closed

CPUs and memory limitation for Docker containers #951

grossmj opened this issue Jul 31, 2020 · 6 comments
Milestone

Comments

@grossmj
Copy link
Member

grossmj commented Jul 31, 2020

Starting with GNS3 2.3, users can limit the amount of memory and CPU resources a Docker container can use.

Screenshot from 2020-07-31 14-22-55

The two new properties are:

  • memory: maximum amount of memory the container can use in MB (integer), for instance 1024MB will limit the container to use a maximum 1GB of RAM.
  • cpus: maximum amount of CPU resources the container can use (float), for instance 0.5 will limit the container to 50% of a CPU core.
@grossmj grossmj added this to the 2.3 milestone Jul 31, 2020
@piotrpekala7
Copy link
Contributor

added in 8d795eb in node configurator, branch master-2.3

@piotrpekala7
Copy link
Contributor

when I try to test it and drag docker node on topology I receive following error: Cannot connect to compute 'GNS3 VM with request POST', server branch 2.3, similar issue in GUI repo GNS3/gns3-gui#2969

@piotrpekala7
Copy link
Contributor

by the way, I don't know why, but the configurator for this type of nodes in the web UI does not cover all the functions from the old interface

@grossmj
Copy link
Member Author

grossmj commented Sep 5, 2020

We shouldn't allow negative values and default value for CPUs should be 0.0 to show that float value is allowed. Also, MB should be added as a suffix for the memory field.

Screenshot from 2020-09-05 17-33-41

@grossmj
Copy link
Member Author

grossmj commented Sep 5, 2020

by the way, I don't know why, but the configurator for this type of nodes in the web UI does not cover all the functions from the old interface

I will open an new issue for this.

@piotrpekala7
Copy link
Contributor

ok added in 169a06f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants