-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Solidity v0.5.0 #21
Conversation
* Vanity updates * Add type cast method to `bytes32` * Update to the natSpec comment on top of both libraries 😄 Though I really like Nick Johnson's string library this has been built entirely by me (as opposed to what the NatSpec comment in the top said since the last commit 😄) I just copied the comment layout on top of his library and forgot to change the author 😂 * Adding Solidity highlight to gitattribute 🎉 😄 * Update package versions & prepare for NPM publish * Create a NPM ignore file to keep `truffle.js` from being published * Syntax & pragmas updates for v0.5.0 * Update README to reflect NPM publish * Another README update * Support for typecasting into uint8, uint16, uint32 (GNSPS#19) * Add uint8, uint16, uint32 * Unit test for uint8, uint16, uint32 * Removing Truffle as a dependency * Bump version to v0.0.6
* Style changes * Added `memory` everywhere to bytes and strings * `target.call(data)` now returns a tuple
I just changed the target branch to |
ThrowProxy was giving problems while testing with the JS-VM with the Constantinople hard-fork. So I changed the tests to stop using that pattern and use function selectors since that's now a thing. It is cleaner now.
Ok, test are passing now on my machine. Overall ditching the ThrowProxy was probably a good Let me know if you're ok with me merging the request as is @fubuloubu . |
Looking good for me. The tests complain about the following unused variables:
It looks like in your tests, this doesn't match up with what I think is intended (I'd expect each |
* (WIP) Upgrade to Solidity v0.5.0 (#21) * (refactor) Changed codebase to Solidity v0.5.0 * Style changes * Added `memory` everywhere to bytes and strings * `target.call(data)` now returns a tuple * Adding note about compiler support in the README + typo fix * Replaced the ThrowProxy pattern for a better v0.5.x one ThrowProxy was giving problems while testing with the JS-VM with the Constantinople hard-fork. So I changed the tests to stop using that pattern and use function selectors since that's now a thing. It is cleaner now. * Update package-lock.json * Bump version to v0.0.7 * Bump version in package-lock.json * Update dependency versions * Fix typo in package-lock.json
memory
everywhere to bytes and stringstarget.call(data)
now returns a tuple