Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of Windows build #23

Closed
onkarshinde opened this issue Mar 16, 2018 · 9 comments
Closed

Future of Windows build #23

onkarshinde opened this issue Mar 16, 2018 · 9 comments
Assignees
Labels
build Issues related to build
Milestone

Comments

@onkarshinde
Copy link
Contributor

I have not found any way to get the Windows cross compilation build work with GTK3.

  • Windows will have to stay on GTK 2 for the foreseeable future.
  • Non-Windows build should move to GTK3 permanently. It does not make sense to maintain GTK2 build option for non-Windows platform.

In order to make code maintainable

  • We should create a source subfolder for Windows
  • Copy all the GUI related files to this folder
  • Modify Makefile.am to use different files based on build type.
@onkarshinde onkarshinde self-assigned this Mar 16, 2018
@onkarshinde
Copy link
Contributor Author

@srid Your opinion please.

@srid
Copy link
Member

srid commented Mar 17, 2018

What is the problem with GTK3 Windows build?

I'd rather entirely drop GTK2 support than end up having to maintain Windows specific GUI files.

@onkarshinde
Copy link
Contributor Author

Our current Windows build mechanism is using mingw cross compiler and GTK2 pre-built binaries. There are no pre-built GTK3 binaries for Windows.
It may be possible to create a build using MSYS2 environment but I do not have access to a Windows machine to do any experiments.

@onkarshinde
Copy link
Contributor Author

@srid Some good news. Fedora includes GTK3 binaries built with mingw. So it is possible to do cross compilation using these binaries and create GTK3 build for Windows.
I have now set up Fedora in virtual box machine. Will work on this in next few weeks.

@onkarshinde
Copy link
Contributor Author

I have managed to get a build done on Fedora that includes all GTK3 and required libraries in one installer. But for some reason when this is installed some of the icons do not show up in UI. Looking at the log in console I can see issue loading icons from the theme.
I copied the entire Adwaita theme to installation folder and still could not resolve the issue.

After reading through lot of discussions on internet I have come across EasyTAG application which uses almost same setup as us. The application is using GTK3, built for windows using Mingw and using NSIS to create installer. I am planning to look at how the installer is created for EasyTAG and see if we can borrow some of the logic.

@onkarshinde onkarshinde added the build Issues related to build label Jun 7, 2018
@onkarshinde
Copy link
Contributor Author

gnusim8085_gtk3_windows_tested_in_wine

@srid I have made good progress after lot of efforts and managed to create a installer build that includes all the dependencies. Please see the screenshot when I tested this using wine. Would you like to test this on a real Windows machine before I commit the changes? I can provide the installer in Google Drive.

@srid
Copy link
Member

srid commented Jul 19, 2018

@onkarshinde I do not have a Windows machine, perhaps some of the interested Windows users would be willing to test the executable?

@onkarshinde
Copy link
Contributor Author

gnusim8085

@srid Tested the application on a Windows 7 machine now. Please see the screenshot.

@srid
Copy link
Member

srid commented Jul 20, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to build
Projects
None yet
Development

No branches or pull requests

2 participants