Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save_optics crashes if P, D not specified #36

Open
GNiendorf opened this issue Sep 7, 2024 · 0 comments
Open

save_optics crashes if P, D not specified #36

GNiendorf opened this issue Sep 7, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@GNiendorf
Copy link
Owner

If P, D of each surface are not specified (so D's default value of [0., 0., 0.] is assumed) then save_optics crashes. This function should be reworked to iterate over the surfaces first, handling these edge cases, and then converting to a pd dataframe at the end to export as csv.
@GNiendorf GNiendorf added bug Something isn't working good first issue Good for newcomers labels Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GNiendorf