Update the regular expressions for emails in validation #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofu-rocketry
previously approved these changes
Apr 2, 2020
|
@tofu-rocketry it's built on top of #146 and a previous version of dev. Once #146 is merged into dev I can easily rebase onto dev. |
|
Ah, it's one of those. |
|
will probably need further rebasing as I've just closed #246 |
Update the x email regexs to reflect the HTML5 spec[1]. As this is xml, ampersands need escaping as special chracters. [1] https://html.spec.whatwg.org/#e-mail-state-(type=email)
|
rebased on top of dev and ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147, depends on
#146.Update the x email regexs to reflect the HTML5 spec[1]. As this is xml,
ampersands need escaping as special characters.
[1] https://html.spec.whatwg.org/#e-mail-state-(type=email)