Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates #213

Merged
merged 2 commits into from Apr 7, 2020
Merged

Minor updates #213

merged 2 commits into from Apr 7, 2020

Conversation

GRyall
Copy link
Contributor

@GRyall GRyall commented Apr 6, 2020

  • Rename a function in write API for clarity
  • Update to comment in write API for clarity
  • Deletion of commented out code from test suites

@GRyall
delete commented code from test suite
daed7fe
@GRyall
Rename function for clarity
4b58d21 
* Within Write API rename the function that processes URLs to make clear
that is all it does (ie remove 'getAnd' prefix)
*update a comment within this function for clarity
@GRyall GRyall added this to the 5.7.6 milestone Apr 6, 2020
gregcorbett
gregcorbett approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregcorbett gregcorbett self-assigned this Apr 7, 2020
@gregcorbett gregcorbett merged commit 71d2ca2 into GOCDB:dev Apr 7, 2020
@GRyall GRyall deleted the minorWriteAPIUpdate branch April 16, 2020 09:56
@gregcorbett gregcorbett modified the milestones: 5.7.6, 5.8.0 Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregcorbett gregcorbett gregcorbett approved these changes

@tofu-rocketry tofu-rocketry Awaiting requested review from tofu-rocketry

@ineilson ineilson Awaiting requested review from ineilson

Assignees

@gregcorbett gregcorbett

Labels
enhancement
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GRyall @gregcorbett