Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make urls in the extension properties table clickable #243

Merged
merged 2 commits into from Feb 9, 2021
Merged

Make urls in the extension properties table clickable #243

merged 2 commits into from Feb 9, 2021

Conversation

sarahbyrnie
Copy link
Contributor

Resolves #232

@gregcorbett
Copy link
Member

gregcorbett commented Aug 11, 2020 •
edited

The effect of this change is visible here.

@gregcorbett gregcorbett requested a review from a team August 11, 2020 16:06
@gregcorbett gregcorbett self-assigned this Aug 11, 2020
@gregcorbett gregcorbett added this to the 5.7.6 milestone Aug 11, 2020
@ineilson
Copy link
Contributor

The effect of this change is visible here.

I don't see clickable links ?

image

@gregcorbett
Copy link
Member

what happens if you hover your mouse over them?

@ineilson
Copy link
Contributor

what happens if you hover your mouse over them?

I was on https://host-130-246-214-232.nubes.stfc.ac.uk/portal/index.php?Page_Type=Site&id=61 which the 'here' link pointed to then. It works fine on current link - https://host-172-16-103-201.nubes.stfc.ac.uk/portal/index.php?Page_Type=Site&id=61

GRyall
GRyall previously approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@GRyall GRyall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's borderline too much php for the view layer

@gregcorbett gregcorbett modified the milestones: 5.7.6, 5.8.0 Aug 17, 2020
@sarahbyrnie @jrha
Update htdocs/web_portal/views/fragments/viewPropertiesTable.php
724a539 
Co-authored-by: James Adams <james.adams@stfc.ac.uk>
gregcorbett
gregcorbett approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@gregcorbett gregcorbett merged commit dbf0476 into GOCDB:dev Feb 9, 2021
@sarahbyrnie sarahbyrnie deleted the issue232 branch February 24, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrha jrha jrha left review comments

@gregcorbett gregcorbett gregcorbett approved these changes

@GRyall GRyall GRyall left review comments

Assignees

@gregcorbett gregcorbett

Labels
enhancement
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

Clickable extension property url
5 participants
@sarahbyrnie @gregcorbett @ineilson @jrha @GRyall