Unregistered user protected messages fix #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofu-rocketry
changed the title
jrha
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
This change looks good to me.
It feels like a further improvement would be to start defining "standard" error messages like these as constants in a separate file, which should discourage the adding of more non-standard message and possibly improve future portability/customisation/translation.
Improve 'protected' messages to clarify that registration is required and not just "auth" as you need a grid cert to get that far anyway.
Make logic for auth check for getEmail consistent with other occurences within view_service.
tofu-rocketry
force-pushed
the
248-unregistered-msg
branch
from
1c1ad6f
to
c9cd260
Compare
Issue opened at #259 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #248.
This PR corrects the spelling and also improves the messages, wherever they occur in the codebase, to clarify that registration is required and not just "auth" as you need a grid cert to get that far anyway.
Also makes the PHP logic around one of the instances consistent with the others in the same file.