Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling to read only message #251

Merged
merged 1 commit into from Feb 1, 2021

Conversation

tofu-rocketry
Copy link
Member

@tofu-rocketry tofu-rocketry commented Aug 24, 2020

Resolves #65 (which isn't quite 4 years old yet).

This corrects the placement of the message so it appears below the GOCDB + version line and also changes it to all caps to make it more obvious.

Only tested by making edits through Firefox Web Dev tools Inspector, though it only touches HTML so should be safe, but actual testing would be a good idea.

This corrects the placement of the message so it appears below the
GOCDB + version line and also changes it to all caps to make it more
obvious.
Copy link
Contributor

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and seems to work as expected on both Firefox and Chrome.

@gregcorbett gregcorbett added this to the 5.8.0 milestone Feb 1, 2021
@gregcorbett gregcorbett merged commit 1ade52b into GOCDB:dev Feb 1, 2021
@tofu-rocketry tofu-rocketry deleted the 65-read-only-msg branch February 1, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read only mode warning appears in wrong place
3 participants