Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL-based configuration monitoring fixes #264

Merged
merged 5 commits into from Aug 23, 2021
Merged

URL-based configuration monitoring fixes #264

merged 5 commits into from Aug 23, 2021

Conversation

ineilson
Copy link
Contributor

@ineilson ineilson commented Jan 19, 2021

Resolves #263

Enable monitoring pages to use url-based configuration plus minor logic fixes.

@gregcorbett
Copy link
Member

Looks good :), could 1e9bdfb be factored out into it's own separate PR though?

@gregcorbett gregcorbett self-assigned this Jan 21, 2021
@gregcorbett gregcorbett added this to the 5.8.0 milestone Jan 21, 2021
@ineilson
Copy link
Contributor Author

Yes, of course, it was kind of a mistake that it slipped through but I hoped you wouldn't notice ;-)

@gregcorbett gregcorbett requested a review from a team February 1, 2021 16:24
Correct to PSR-12 code style. See also  #270

Co-authored-by: gregcorbett <gregcorbett@users.noreply.github.com>
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregcorbett gregcorbett merged commit c69fc90 into GOCDB:dev Aug 23, 2021
@ineilson ineilson deleted the filter-by-scope-fixes branch February 14, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/portal/GOCDB_monitor/ checks the status of the default server when in a URL-specific view
2 participants