Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #146" #307

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

gregcorbett
Copy link
Member

This PR deliberately branches off of and merges into master.

For reference, this essentially reverts the state of master back to PR #212 (5d6dea3)

$ git diff revert-146 5d6dea360a536438d0072192b1070108ac5954a9
$

I intend to merge via a "Squash and merge".

- This reverts commit d181cf6,
  reversing changes made to
  5d6dea3.
- PR GOCDB#146 was erroneously merged into master.
- I don't want this feature (Allow multi email input for
  Service Group EMAIL) in 5.7.6 as it is not part of that
  release branch so has not been tested in preproduction.
- PR GOCDB#247 ensures the feature is in the dev branch. The feature is
  already part of the release-5.8.0 branch.
@gregcorbett gregcorbett merged commit 69c7e11 into GOCDB:master Oct 15, 2021
@gregcorbett gregcorbett deleted the revert-146 branch October 15, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants