Fixes to tiff.js to work in Chrome #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- got rid of default parameters (as cool as they are) -- got rid of const (as nice as it is)
GPHemsley
added a commit
that referenced
this pull request
Nov 21, 2012
Fixes to tiff.js to work in Chrome
|
Great, thanks! |
|
I've pretty much undone commit 9a9291f with commit 9d6e3c5. I generally test the script with by refreshing with a file already loaded, so having the onload trigger would prompt the image to be reparsed on refresh, instead of me having to manually reload the image. I also changed the default background color to something that is a little more obvious (#FFEEFF). Having it solid black could lead to confusion as whether an image was parsed correctly, if an image actually has a lot of black in it. Along those lines, I've also (in commit f1ad327) made it so that the canvas border changes from dashed to solid when the image is loaded. Hopefully these changes will satisfy the same usecase requirements as your original commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making tiff.js, it's been a great help for a project I am working on. I had to make some minor changes to get it to work in Chrome. Chrome does not like
constin strict mode (since it's not yet part of the standard), and Chrome does not support default parameters (which is a Firefox proprietary feature).