Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPII-4306: Modify docker image build to record full SHA revision #71

Merged
merged 1 commit into from Feb 5, 2020
Merged

GPII-4306: Modify docker image build to record full SHA revision #71

merged 1 commit into from Feb 5, 2020

Conversation

klown
Copy link
Member

@klown klown commented Jan 14, 2020 •
edited

Retrieves the full SHA256 of the git revision used to make the gpii-universal image and passes that SHA to the docker build process.

This requires changes to the Dockerfile implemented in pull #836

JIRA: https://issues.gpii.net/browse/GPII-4306

@klown
GPII-4306: Modified docker image build
5646d9a 
Retrieves the full SHA256 of the git revision used to make the
gpii-universal image and passes that SHA to the docker build process.
@klown
Copy link
Member Author

klown commented Jan 14, 2020 •
edited

@amatas, based on @stepanstipl's suggestion, I have modified gpii-universal's Dockerfile and ci-service's build script such that the full SHA git revision will be written to the root directory of the docker image as a .json file.

I have tested the Dockerfile, but I don't know how to test the ci-service script. Is there a way to do that?

@klown klown mentioned this pull request Jan 14, 2020
Merged
@klown
Copy link
Member Author

klown commented Jan 28, 2020

Ready for review, @amatas

@amatas amatas self-requested a review January 29, 2020 15:10
amatas
amatas approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@amatas amatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klown
Copy link
Member Author

klown commented Feb 5, 2020

@amatas Is there anything I need to do move this along?

Note: @amb26 merged the associated universal PR #836

@amatas amatas merged commit 18be31f into GPII:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amatas amatas amatas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@klown @amatas