New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPII-2307: Add combined code coverage reports. #508
Changes from 18 commits
e173cd4
88b1cea
c58a1c5
44426ee
f3c0828
e903c26
39e8cad
80ab887
3af8ebb
d67a12d
76694bd
f07b196
85e2a9c
e115ee3
fbda4da
75699b4
bf8eb0a
7185106
b95df8f
30b5a4f
02cdbd6
3155daa
a4a95e7
456ba1c
b24c923
304a887
f9a1e43
017d88f
1dc0f9c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,3 +13,7 @@ Vagrantfile.local | |
.vagrant/ | ||
|
||
report.tap | ||
coverage | ||
.nyc_output | ||
instrumented | ||
reports |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You said "You should not need to run the
pretest
scripts manually". What aboutposttest
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have an answer for this question. Please let me know if it makes sense.
posttest
will automatically run at runningnpm test
but would not be automated when running browser and node tests individually. However, running them individually already has a jQunit result report so that having another testem report becomes unnecessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the wording to reflect that you don't need to run either.
Just to clarify, as I pointed out in other comments, neither of the individual commands will result in a coverage report. They do (as you say) display the results of the test runs.