Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
GPII-3333: Improve production tests to cover more functionality #718
referenced this pull request
Dec 12, 2018
The technique to remove the extra access tokens is okay, but could be improved. It uses the GPII Key IDs used in the tests to find a subset of access tokens in the database and remove that group. One ID, however, is used elsewhere, namely "carla"; so this will remove all of carla's access tokens, even ones created outside of these tests.
An improvement is to use the timestamps within the access tokens, relying on the fact that the "test" access tokens were all created within the last hour (practically speaking, within the last five minutes, or less).
Ideally, the code should remove all-and-only the access tokens that were created by the tests. But, because the database cleanup code is run in a separate
A followup to my comments above. I wrote:
Note that the set-up code in
Why not use the flowmanager's
The latest technique is an improvement over the previous one.. It stores the access tokens that the tests create when making flowmanager
A few access tokens are still missed, however: