New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add check for typos #1516
[CI] Add check for typos #1516
Conversation
Test summary for commit ae18682Driver commits used in build
CTS tests (Failed: 0/225388)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to run this locally, outside of CI?
Yes, just install typos and run |
Can we make the workflow print such instructions when the check step fails? |
I don’t see an easy way to do this. I tried printing instructions in another step after the spell checking, but you have to expand that step explicitly to see the instructions (see https://github.com/Flakebi/llpc/runs/4191321244?check_suite_focus=true, my step name of |
How about we print those instructions before we run the check step? I'd just like to have something that once can refer to if they see this check fail on their PR. |
Add a github CI workflow that checks for typos.
I named the step “Help”, hopefully that makes it attractive for people to open it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm dyslexic and make tons of typos, tools like this are very helpful.
Add a github CI workflow that checks for typos.
Example for a failing run: Flakebi#5