Propagate specified entry points to the shader compiler #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary for commit 11b26feDriver commits used in build
CTS tests (Failed: 0/218612)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
dstutt
reviewed
Dec 14, 2021
Ah no, just realised that m_compileInfo -> moduleData wasn't a change of member name. I'll update the review. |
Push per-input entry point down the standalone compiler. Also: - Remove the now obsolete `-entry-target` option. - Fix a bug where non-'main' GLSL entry points would be accepted but result in empty SPIR-V functions. Disallow non-'main' entry point names when compiling GLSL to match glslang. - Refactor input stage processing. Introduce a helper function for each input kind.
|
V1. Rebase, no code changes. |
Test summary for commit 744b3adDriver commits used in build
CTS tests (Failed: 0/218612)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
amdrexu
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push per-input entry point down the standalone compiler.
Also:
-entry-targetoption.result in empty SPIR-V functions. Disallow non-'main' entry point
names when compiling GLSL to match glslang.
each input kind.